Enable workflow testing + fix header #8512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR enhances workflow testing capabilities and improves header functionality across the application. Here's a concise summary of the key changes:
- Modified
runWorkflowVersionhook to use a more explicit object parameter structure withworkflowVersionIdand optionalpayload - Added workflow test validation in
RecordShowPageWorkflowHeaderwith snackbar notifications for success/error states - Added
isWorkflowSubObjectMetadatacheck inShowPageAddButtonto prevent showing add button for workflow-related objects - Added new workflow run query hooks in server module for update/delete operations
- Improved error handling with descriptive snackbar messages when workflows cannot be tested
The changes appear well-structured and improve both the developer and user experience around workflow testing and management.
9 file(s) reviewed, 8 comment(s)
Edit PR Review Bot Settings | Greptile
...tion-menu/actions/global-actions/workflow-run-actions/components/WorkflowRunActionEffect.tsx
Show resolved
Hide resolved
...tion-menu/actions/global-actions/workflow-run-actions/components/WorkflowRunActionEffect.tsx
Show resolved
Hide resolved
...ions/record-actions/workflow-run-record-actions/components/WorkflowRunRecordActionEffect.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageAddButton.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/ui/layout/show-page/components/ShowPageMoreButton.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/components/RecordShowPageWorkflowHeader.tsx
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/components/RecordShowPageWorkflowHeader.tsx
Outdated
Show resolved
Hide resolved
packages/twenty-front/src/modules/workflow/hooks/useRunWorkflowVersion.ts
Show resolved
Hide resolved
thomtrp
force-pushed
the
tt-fix-version-and-run-header
branch
from
2d91b81 to
5cb0d18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behaviour still need to be validated by @Bonapara
